[lkml]   [2010]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 3/9 - v2][RFC] tracing: Remove per event trace registering
    * Frederic Weisbecker ( wrote:
    > On Mon, May 03, 2010 at 11:40:48PM -0400, Steven Rostedt wrote:
    > > From: Steven Rostedt <>
    > >
    > > This patch removes the register functions of TRACE_EVENT() to enable
    > > and disable tracepoints. The registering of a event is now down
    > > directly in the trace_events.c file. The tracepoint_probe_register()
    > > is now called directly.
    > >
    > > The prototypes are no longer type checked, but this should not be
    > > an issue since the tracepoints are created automatically by the
    > > macros. If a prototype is incorrect in the TRACE_EVENT() macro, then
    > > other macros will catch it.
    > Agreed. Typechecking matters for human code but not in this context.
    > Considering that the tracepoint and the probe are created by the same
    > CPP code, bugs will be tracked down quickly and located to a single
    > place.

    So it seems that I am the only one asking for extra type-checking and
    caring about problems that can appear subtily on architectures where the
    number of caller/callee arguments must match. And also the only one
    considering that passing more arguments to a callback that does not
    expect all of them might be a problem on some architectures.

    Am I the only one thinking there is something fishy there ? I might be
    entirely over-paranoid, but this approach has rarely failed me in the



    Mathieu Desnoyers
    Operating System Efficiency R&D Consultant
    EfficiOS Inc.

     \ /
      Last update: 2010-05-07 16:57    [W:0.024 / U:32.472 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site