Messages in this thread | | | Date | Fri, 07 May 2010 16:20:33 +0800 | From | Li Zefan <> | Subject | Re: [PATCH 3/9 - v2][RFC] tracing: Remove per event trace registering |
| |
> @@ -935,11 +947,11 @@ event_create_dir(struct ftrace_event_call *call, struct dentry *d_events, > return -1; > } > > - if (call->regfunc) > + if (call->class->probe || call->class->reg) > trace_create_file("enable", 0644, call->dir, call, > enable); > > - if (call->id && call->perf_event_enable) > + if (call->id && (call->class->perf_probe || call->class->reg)) > trace_create_file("id", 0444, call->dir, call, > id); >
Accessing of ->perf_probe needs to be guarded with CONFIG_PERF_EVENTS, otherwise it won't pass compile.
The original code is fine, because ->perf_event_enable is always there regardless of CONFIG_PERF_EVENTS.
| |