lkml.org 
[lkml]   [2010]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
SubjectRE: [PATCH] ad7877: fix spi word size to 16 bit
Oskar Schirmer wrote on 2010-05-06:
> With no word size given in the users platform data, a generic spi host
> controller driver will assume a default word size of eight bit. This
> causes transmission to be performed bytewise, which will fail on
> little endian machines for sure. Failure on big endian depends on
> usage of slave select to mark word boundaries.
>
> Anyway, ad7877 is specified to work with 16 bit per word, so
> unconditionally set the word size accordingly.
>
> Signed-off-by: Oskar Schirmer <os@emlix.com>
> Signed-off-by: Daniel Glöckner <dg@emlix.com>
> Signed-off-by: Oliver Schneidewind <osw@emlix.com>

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

> ---
> drivers/input/touchscreen/ad7877.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
> diff --git a/drivers/input/touchscreen/ad7877.c
> b/drivers/input/touchscreen/ad7877.c index e019d53..92acd85 100644 ---
> a/drivers/input/touchscreen/ad7877.c +++
> b/drivers/input/touchscreen/ad7877.c @@ -669,6 +669,8 @@ static int
> __devinit ad7877_probe(struct spi_device *spi)
> dev_dbg(&spi->dev, "SPI CLK %d Hz?\n",spi->max_speed_hz);
> return -EINVAL;
> }
> + spi->bits_per_word = 16;
> + spi_setup(spi);
>
> ts = kzalloc(sizeof(struct ad7877), GFP_KERNEL);
> input_dev = input_allocate_device();

Greetings,
Michael

Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 4036 Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif

\
 
 \ /
  Last update: 2010-05-06 13:21    [W:0.346 / U:22.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site