lkml.org 
[lkml]   [2010]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ad7877: keep dma rx buffers in seperate cache lines
    On Thu, May 06, 2010 at 14:46:04 -0400, Mike Frysinger wrote:
    > On Thu, May 6, 2010 at 06:37, Oskar Schirmer wrote:
    > >  struct ser_req {
    > > +       u16                     sample;
    > > +       char                    __padalign[L1_CACHE_BYTES - sizeof(u16)];
    > > +
    > >        u16                     reset;
    > >        u16                     ref_on;
    > >        u16                     command;
    > > -       u16                     sample;
    > >        struct spi_message      msg;
    > >        struct spi_transfer     xfer[6];
    > >  };
    >
    > are you sure this is necessary ? ser_req is only ever used with
    > spi_sync() and it's allocated/released on the fly, so how could
    > anything be reading that memory between the start of the transmission
    > and the return to adi7877 ?

    msg is handed over to spi_sync, it contains the addresses
    which will be used to programme the DMA: the spi master
    transfer function will read these fields to start DMA.

    E.g., drivers/spi/atmel_spi.c, assures cache coherency
    in function atmel_spi_dma_map_xfer, one xfer at a time.
    Multiple transfers are worked on in a loop in atmel_spi_transfer,
    so when coherency for transfer #1 is ensured, addresses
    for transfer #2 are read from the msg and xfer structs,
    caching lines which have been just before invalidated.

    And, citing Documentation/DMA-API.txt, Part Id:
    "mapped region must begin exactly on a cache line
    boundary and end exactly on one", which is our case.

    >
    > >  struct ad7877 {
    > > +       u16                     conversion_data[AD7877_NR_SENSE];
    > > +       char                    __padalign[L1_CACHE_BYTES
    > > +                                       - AD7877_NR_SENSE * sizeof(u16)];
    > > +
    > >        struct input_dev        *input;
    > >        char                    phys[32];
    > >
    > > @@ -182,8 +188,6 @@ struct ad7877 {
    > >        u8                      averaging;
    > >        u8                      pen_down_acc_interval;
    > >
    > > -       u16                     conversion_data[AD7877_NR_SENSE];
    > > -
    > >        struct spi_transfer     xfer[AD7877_NR_SENSE + 2];
    > >        struct spi_message      msg;
    >
    > i can see the spi_message inside of this struct being a problem
    > because the spi transfer is doing asynchronously with spi_async().
    > however, i would add a comment right above these two fields with a
    > short explanation as to why they're at the start and why the pad
    > exists so someone down the line doesnt move it.

    The code says "pad to align according to L1 cache, and
    keep away other stuff by exactly the amount so it is
    off the line". I'ld guess a comment would repeat just
    this, so it is superfluous. But if opinions differ on
    this topic, we can have a comment added, sure.

    Oskar
    --
    oskar schirmer, emlix gmbh, http://www.emlix.com
    fon +49 551 30664-0, fax -11, bahnhofsallee 1b, 37081 göttingen, germany
    sitz der gesellschaft: göttingen, amtsgericht göttingen hr b 3160
    geschäftsführer: dr. uwe kracke, ust-idnr.: de 205 198 055

    emlix - your embedded linux partner
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-05-07 12:19    [W:0.030 / U:0.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site