lkml.org 
[lkml]   [2010]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] cxgb4i_v3: iscsi and libcxgbi library for handling common part
On 05/15/2010 12:24 PM, Rakesh Ranjan wrote:
> From: Rakesh Ranjan<rranjan@chelsio.com>
>
>
> Signed-off-by: Rakesh Ranjan<rakesh@chelsio.com>
> ---
> drivers/scsi/cxgb4i/cxgb4i_iscsi.c | 617 ++++++++++++++++++++++++++++++++++++
> drivers/scsi/cxgb4i/libcxgbi.c | 589 ++++++++++++++++++++++++++++++++++
> drivers/scsi/cxgb4i/libcxgbi.h | 430 +++++++++++++++++++++++++

I think the patch had some whitespace/newline issues. When I did git-am
I got:

warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.

I think James can just fix up when he merges with git, but in the future
you might want to try a git-am on your patch before you send (git-am
--whitespace=fix will fix it up for you).



> +
> +int cxgbi_pdu_init(struct cxgbi_device *cdev)
> +{
> + if (cdev->skb_tx_headroom> (512 * MAX_SKB_FRAGS))
> + cdev->skb_extra_headroom = cdev->skb_tx_headroom;
> + cdev->pad_page = alloc_page(GFP_KERNEL);
> + if (cdev->pad_page)
> + return -ENOMEM;
> + memset(page_address(cdev->pad_page), 0, PAGE_SIZE);
> + return 0;
> +
> + /*
> + if (SKB_TX_HEADROOM> (512 * MAX_SKB_FRAGS))
> + skb_extra_headroom = SKB_TX_HEADROOM;
> + pad_page = alloc_page(GFP_KERNEL);
> + if (!pad_page)
> + return -ENOMEM;
> + memset(page_address(pad_page), 0, PAGE_SIZE);
> + return 0;*/

Clean this up.

> +
> +void cxgbi_release_itt(struct iscsi_task *task, itt_t hdr_itt)
> +{
> + struct scsi_cmnd *sc = task->sc;
> + struct iscsi_tcp_conn *tcp_conn = task->conn->dd_data;
> + struct cxgbi_conn *cconn = tcp_conn->dd_data;
> + struct cxgbi_device *cdev = cconn->chba->cdev;
> + struct cxgbi_tag_format *tformat =&cdev->tag_format;
> + u32 tag = ntohl((__force u32)hdr_itt);
> +
> + cxgbi_tag_debug("release tag 0x%x.\n", tag);
> +
> + if (sc&&
> + (scsi_bidi_cmnd(sc) ||
> + sc->sc_data_direction == DMA_FROM_DEVICE)&&
> + cxgbi_is_ddp_tag(tformat, tag))

The formatting is a little weird. I think you want each line to start in
the same column instead of each getting tabbed over.


> +
> +
> +int cxgbi_reserve_itt(struct iscsi_task *task, itt_t *hdr_itt)
> +{
> + struct scsi_cmnd *sc = task->sc;
> + struct iscsi_conn *conn = task->conn;
> + struct iscsi_session *sess = conn->session;
> + struct iscsi_tcp_conn *tcp_conn = conn->dd_data;
> + struct cxgbi_conn *cconn = tcp_conn->dd_data;
> + struct cxgbi_device *cdev = cconn->chba->cdev;
> + struct cxgbi_tag_format *tformat =&cdev->tag_format;
> + u32 sw_tag = (sess->age<< cconn->task_idx_bits) | task->itt;
> + u32 tag;
> + int err = -EINVAL;
> +
> + if (sc&&
> + (scsi_bidi_cmnd(sc) ||
> + sc->sc_data_direction == DMA_FROM_DEVICE)&&
> + cxgbi_sw_tag_usable(tformat, sw_tag)) {


Same tabbing.


> + volatile unsigned int state;

I did not get why this needed to be volatile (I see it is like this in
cxgb3i and I did not see why in there too).



> +
> +static inline void cxgbi_sock_hold(struct cxgbi_sock *csk)
> +{
> + atomic_inc(&csk->refcnt);


We want people to use krefs instead of their own refcounting now.

> +
> +static inline void *cplhdr(struct sk_buff *skb)
> +{
> + return skb->data;
> +}


Seems kinda useless.


\
 
 \ /
  Last update: 2010-05-27 08:01    [W:0.036 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site