Messages in this thread | | | Date | Mon, 17 May 2010 10:07:05 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH] x86: unify current 3 similar ways of saving IRQ info |
| |
On Mon, 17 May 2010, Feng Tang wrote:
> > -static void __init assign_to_mp_irq(struct mpc_intsrc *m,
Why are you removing __init ?
> +static void assign_to_mp_irq(struct mpc_intsrc *m, > struct mpc_intsrc *mp_irq) > { > mp_irq->dstapic = m->dstapic; > @@ -190,7 +190,7 @@ static void __init assign_to_mpc_intsrc(struct mpc_intsrc *mp_irq, > m->dstirq = mp_irq->dstirq; > } > > -static int __init mp_irq_mpc_intsrc_cmp(struct mpc_intsrc *mp_irq, > +static int mp_irq_mpc_intsrc_cmp(struct mpc_intsrc *mp_irq, > struct mpc_intsrc *m)
Ditto
> { > if (mp_irq->dstapic != m->dstapic) > @@ -211,7 +211,8 @@ static int __init mp_irq_mpc_intsrc_cmp(struct mpc_intsrc *mp_irq, > return 0; > } > > -static void __init MP_intsrc_info(struct mpc_intsrc *m) > +/* Will also be called in acpi/sfi related code */ > +void mp_save_irq(struct mpc_intsrc *m)
Again, this code is called from __init context only and should stay __init.
Thanks,
tglx
| |