Messages in this thread Patch in this message | | | Date | Fri, 14 May 2010 21:29:03 +0200 (CEST) | From | Julia Lawall <> | Subject | [PATCH 3/10] drivers/acpi: Use kstrdup |
| |
From: Julia Lawall <julia@diku.dk>
Use kstrdup when the goal of an allocation is copy a string into the allocated region.
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression from,to; expression flag,E1,E2; statement S; @@
- to = kmalloc(strlen(from) + 1,flag); + to = kstrdup(from, flag); ... when != \(from = E1 \| to = E1 \) if (to==NULL || ...) S ... when != \(from = E2 \| to = E2 \) - strcpy(to, from); // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- drivers/acpi/scan.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff -u -p a/drivers/acpi/scan.c b/drivers/acpi/scan.c --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c @@ -1024,13 +1024,12 @@ static void acpi_add_id(struct acpi_devi if (!id) return; - id->id = kmalloc(strlen(dev_id) + 1, GFP_KERNEL); + id->id = kstrdup(dev_id, GFP_KERNEL); if (!id->id) { kfree(id); return; } - strcpy(id->id, dev_id); list_add_tail(&id->list, &device->pnp.ids); }
| |