Messages in this thread | | | Date | Tue, 11 May 2010 20:37:17 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [trivial PATCH] arch/x86: Remove unnecessary returns from void function()'s |
| |
On 05/11/2010 06:53 PM, Joe Perches wrote: > > Just a stat from arch/x86: > > There may be a little over 2000 void functions in arch/x86/, > 40 use returns before the trailing brace. > > Call it churn or consistency, <shrug>. >
No, please get something straight:
Consistency is not an end in itself. Readability is, however.
Avoiding churn, however, is *also* an end in itself. Sometimes churn is motivated by an increase in readability. Churn is *not* motivated just for "consistency" unless it improves readability.
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |