lkml.org 
[lkml]   [2010]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 0/3] perf/core, x86: unify perfctr bitmasks
    From
    On Mon, Mar 29, 2010 at 6:36 PM, Robert Richter <robert.richter@amd.com> wrote:
    > This patch set unifies performance counter bit masks for x86. All mask
    > are almost the same for all x86 models and thus can use the same macro
    > definitions in arch/x86/include/asm/perf_event.h. It removes duplicate
    > code. There is also a patch that reverts some changes of the big
    > perf_counter -> perf_event rename.
    >

    But there are still fields which are unique to each vendor:
    - GUEST vs. HOST on AMD
    - ANY_THREAD on Intel.

    For instance, I noticed that in

    arch/x86/kernel/cpu/perf_event.c:__hw_perf_event_init():

    if (attr->type == PERF_TYPE_RAW) {
    hwc->config |= x86_pmu.raw_event(attr->config);
    if ((hwc->config & ARCH_PERFMON_EVENTSEL_ANY) &&
    perf_paranoid_cpu() && !capable(CAP_SYS_ADMIN))
    return -EACCES;
    return 0;
    }

    Assumes ANY also exists on AMD processors. That is not the case.
    This check needs to be moved into an Intel specific function.


    \
     
     \ /
      Last update: 2010-03-30 12:15    [W:0.020 / U:93.732 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site