Messages in this thread Patch in this message | | | Date | Mon, 29 Mar 2010 17:36:02 +0200 (CEST) | From | Julia Lawall <> | Subject | [PATCH 9/12] drivers/scsi/qla2xxx: Add missing unlock |
| |
From: Julia Lawall <julia@diku.dk>
This code represents error handling code. Add an unlock as done in the normal exit path from the function.
A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @r exists@ expression E1; identifier f; @@
f (...) { <+... * spin_lock_irqsave (E1,...); ... when != E1 * return ...; ...+> } // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- drivers/scsi/qla2xxx/qla_attr.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c index 90d1e06..e8ace7a 100644 --- a/drivers/scsi/qla2xxx/qla_attr.c +++ b/drivers/scsi/qla2xxx/qla_attr.c @@ -2392,6 +2392,7 @@ done: kfree(sp->fcport); kfree(sp->ctx); mempool_free(sp, ha->srb_mempool); + spin_unlock_irqrestore(&ha->hardware_lock, flags); return 0; }
| |