[lkml]   [2010]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 33/62] i2c: move i2c_omap's probe function to .devinit.text
From: Uwe Kleine-König <>

A pointer to omap_i2c_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded. Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König <>
Cc: Kalle Jokiniemi <>
Cc: Tony Lindgren <>
Cc: Paul Walmsley <>
Cc: Richard Woodruff <>
Cc: chandra shekhar <>
Cc: Jason P Marini <>
Cc: Syed Mohammed Khasim <>
Cc: Jarkko Nikula <>
Cc: Juha Yrjola <>
Cc: Andrew Morton <>
Signed-off-by: Greg Kroah-Hartman <>
drivers/i2c/busses/i2c-omap.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 0037e31..bd86a85 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -849,7 +849,7 @@ static const struct i2c_algorithm omap_i2c_algo = {
.functionality = omap_i2c_func,

-static int __init
+static int __devinit
omap_i2c_probe(struct platform_device *pdev)
struct omap_i2c_dev *dev;
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2010-03-03 00:33    [W:0.260 / U:26.264 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site