lkml.org 
[lkml]   [2010]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 30/62] platform-drivers: move probe to .devinit.text in drivers/scsi
    Date
    From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

    A pointer to a probe callback is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: David Brownell <dbrownell@users.sourceforge.net>
    Cc: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
    Cc: Henrik Kretzschmar <henne@nachtwindheim.de>
    Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
    Cc: Kay Sievers <kay.sievers@vrfy.org>
    Cc: peter fuerst <post@pfrst.de>
    Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
    Acked-by: Ralf Baechle <ralf@linux-mips.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/scsi/sgiwd93.c | 2 +-
    drivers/scsi/sni_53c710.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/scsi/sgiwd93.c b/drivers/scsi/sgiwd93.c
    index 0807b26..fef0e3c 100644
    --- a/drivers/scsi/sgiwd93.c
    +++ b/drivers/scsi/sgiwd93.c
    @@ -226,7 +226,7 @@ static struct scsi_host_template sgiwd93_template = {
    .use_clustering = DISABLE_CLUSTERING,
    };

    -static int __init sgiwd93_probe(struct platform_device *pdev)
    +static int __devinit sgiwd93_probe(struct platform_device *pdev)
    {
    struct sgiwd93_platform_data *pd = pdev->dev.platform_data;
    unsigned char *wdregs = pd->wdregs;
    diff --git a/drivers/scsi/sni_53c710.c b/drivers/scsi/sni_53c710.c
    index 37b3359..56cf0bb 100644
    --- a/drivers/scsi/sni_53c710.c
    +++ b/drivers/scsi/sni_53c710.c
    @@ -64,7 +64,7 @@ static struct scsi_host_template snirm710_template = {
    .module = THIS_MODULE,
    };

    -static int __init snirm710_probe(struct platform_device *dev)
    +static int __devinit snirm710_probe(struct platform_device *dev)
    {
    unsigned long base;
    struct NCR_700_Host_Parameters *hostdata;
    --
    1.7.0.1
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-03-03 00:57    [W:0.035 / U:0.004 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site