Messages in this thread Patch in this message | | | Date | Fri, 19 Mar 2010 14:49:20 +0300 | From | Dan Carpenter <> | Subject | [patch] power_meter: acpi_device_class "power_meter_resource" too long |
| |
acpi_device_class can only be 19 characters and a NULL terminator.
The current code has a buffer overflow in acpi_power_meter_add(): strcpy(acpi_device_class(device), ACPI_POWER_METER_CLASS);
Signed-off-by: Dan Carpenter <error27@gmail.com> --- Feel free to change the name to anything you like.
diff --git a/drivers/acpi/power_meter.c b/drivers/acpi/power_meter.c index 834c5af..31baa1e 100644 --- a/drivers/acpi/power_meter.c +++ b/drivers/acpi/power_meter.c @@ -34,7 +34,7 @@ #define ACPI_POWER_METER_NAME "power_meter" ACPI_MODULE_NAME(ACPI_POWER_METER_NAME); #define ACPI_POWER_METER_DEVICE_NAME "Power Meter" -#define ACPI_POWER_METER_CLASS "power_meter_resource" +#define ACPI_POWER_METER_CLASS "pwr_meter_resource" #define NUM_SENSORS 17
| |