Messages in this thread | | | Date | Thu, 11 Mar 2010 13:58:19 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 2/2] fs/partition/msdos: Fix unusable extended partition for > 512B sector |
| |
On 03/11/2010 01:25 PM, Daniel Taylor wrote: > > I have not yet tried booting from one of these disks. > > They are in USB-attached enclosures,
Right...
> attached well after boot, so the > bootloader has never seen them.
Wrong. A lot of BIOSes will attempt to boot from USB storage. Worse, a fair number of BIOSes will hang during startup if a USB storage device that confuses them -- even if not the primary boot device.
> They simply refuse to mount to a running > Linux system because, when the storage for partition size and start was > expanded to 64-bit, no one bothered to fix the intermediate storage in > msdos.c, so the kernel cannot locate the start nor figure the size of > the partitions. > > Logically, this patch is not complicated. The data types in msdos.c > are flat-out wrong, given that the real stored data is of type sector_t. > The intermediate variables should not be u32.
I would consider this a bugfix. As such, it should be pushed outside the merge window.
-hpa
| |