lkml.org 
[lkml]   [2010]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next requirements (Was: Re: [tip:x86/ptrace] ptrace: Add support for generic PTRACE_GETREGSET/PTRACE_SETREGSET)
Hi Ingo,

On Mon, 22 Feb 2010 11:27:45 +0100 Ingo Molnar <mingo@elte.hu> wrote:
>
> * Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> > On Mon, 22 Feb 2010 10:07:10 +0100 Ingo Molnar <mingo@elte.hu> wrote:
> > >
> > > I'll keep them in tip:master to get them tested, but note that i cannot
> > > push any of these patches into linux-next until this is fixed, as
> > > linux-next requires all architectures to build, with no regard to which
> > > architectures are tested by kernel testers in practice.
> >
> > I merely expect people not to push known broken code into linux-next.
>
> FYI, this 'mere' kind of indiscriminate definition of 'breakage' is what i am
> talking about.

OK, let me remove "merely" from this.

I expect people not to push known broken code into linux-next. Code in
linux-next is meant to be as ready as possible to be sent to Linus. If
you know that it breaks some architecture then it should obviously be
fixed some how (unless the architecture maintainer really doesn't care,
of course).

This is different from not knowing that it breaks some architecture even
though you have done reasonable testing.

> The occasional driver build breakage can be tested relatively easily: one
> allyesconfig build and it's done. Build testing 22 architectures is
> exponentially harder: it requires the setup (and constant maintenance) of
> zillions of tool-chains, plus the build time is significant as well.
>
> So this kind of linux-next requirement causes the over-testing of code that
> doesnt get all that much active usage, plus it increases build testing
> overhead 10-fold. That, by definition, causes the under-testing of code that
> _does_ matter a whole lot more to active testers of the Linux kernel.

Which is why linux-next does *not* require that. (Did you read the part
of my email that you removed?) I do point out when build failures occur
(that is part of the point of linux-next after all) but they only upset
me when it is clear that the code that has been changed was not built at
all (which doesn't happen too often).

> Which is a problem, obviously.

It certainly would be.

Maybe I don't understand what you are trying to say.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2010-02-22 12:51    [from the cache]
©2003-2011 Jasper Spaans