Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [PATCH] dvb: return -ENOMEM if kzalloc failed in dvb_usb_device_init() | Date | Tue, 2 Feb 2010 15:29:36 +0100 |
| |
Am Dienstag, 2. Februar 2010 15:29:46 schrieb Roel Kluin: > If in a cold state and the download succeeded ret is zero, but we > should return -ENOMEM. > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > --- > Or shouldn't we?
We should and we do if cold==0. The bug is caused by this:
if (cold) { info("found a '%s' in cold state, will try to load a firmware",desc->name); ret = dvb_usb_download_firmware(udev,props); if (!props->no_reconnect || ret != 0) return ret; }
which overwrites ret
Regards Oliver
| |