Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [PATCH] dvb: return -ENOMEM if kzalloc failed in dvb_usb_device_init() | Date | Wed, 3 Feb 2010 17:16:03 +0100 |
| |
Am Mittwoch, 3. Februar 2010 17:02:49 schrieb roel kluin: > > The bug is caused by this: > > > > if (cold) { > > info("found a '%s' in cold state, will try to load a firmware",desc->name); > > ret = dvb_usb_download_firmware(udev,props); > > if (!props->no_reconnect || ret != 0) > > return ret; > > } > > > > which overwrites ret > > Is that an ack or do you want me to add an int (e.g. rc) that > handles the dvb_usb_download_firmware() return value?
This is an ack with an additional comment that this function is in need of a cleanup due to unnecessary subtlety.
Regards Oliver
| |