lkml.org 
[lkml]   [2010]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[08/93] hwmon: (adt7462) Wrong ADT7462_VOLT_COUNT
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------
    From: Ray Copeland <ray.copeland@aprius.com>

    commit 85f8d3e5faea8bd36c3e5196f8334f7db45e19b2 upstream.

    The #define ADT7462_VOLT_COUNT is wrong, it should be 13 not 12. All the
    for loops that use this as a limit count are of the typical form, "for
    (n = 0; n < ADT7462_VOLT_COUNT; n++)", so to loop through all voltages
    w/o missing the last one it is necessary for the count to be one greater
    than it is. (Specifically, you will miss the +1.5V 3GPIO input with count
    = 12 vs. 13.)

    Signed-off-by: Ray Copeland <ray.copeland@aprius.com>
    Acked-by: "Darrick J. Wong" <djwong@us.ibm.com>
    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/hwmon/adt7462.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)
    --- a/drivers/hwmon/adt7462.c
    +++ b/drivers/hwmon/adt7462.c
    @@ -182,7 +182,7 @@ I2C_CLIENT_INSMOD_1(adt7462);
    *
    * Some, but not all, of these voltages have low/high limits.
    */
    -#define ADT7462_VOLT_COUNT 12
    +#define ADT7462_VOLT_COUNT 13

    #define ADT7462_VENDOR 0x41
    #define ADT7462_DEVICE 0x62



    \
     
     \ /
      Last update: 2010-02-19 18:23    [from the cache]
    ©2003-2011 Jasper Spaans