[lkml]   [2010]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[82/93] ACPI: Add NULL pointer check in acpi_bus_start
2.6.32-stable review patch.  If anyone has any objections, please let us know.


From: Thomas Renninger <>

commit d2f6650a950dadd20667a04a9dc785f240d43695 upstream.

If acpi_bus_add does not return a device and it's passed
to acpi_bus_start, bad things will happen:

BUG: unable to handle kernel NULL pointer dereference at 0000000000000008
IP: [<ffffffff8128402d>] acpi_bus_start+0x14/0x24
[<ffffffffa008977a>] acpiphp_bus_add+0xba/0x130 [acpiphp]
[<ffffffffa008aa72>] enable_device+0x132/0x2ff [acpiphp]
[<ffffffffa0089b68>] acpiphp_enable_slot+0xb8/0x130 [acpiphp]
[<ffffffffa0089df7>] handle_hotplug_event_func+0x87/0x190 [acpiphp]

Next patch would make this NULL pointer check obsolete, but
better having one more than one missing...

Signed-off-by: Thomas Renninger <>
Acked-by: Bjorn Helgaas <>
Signed-off-by: Len Brown <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/acpi/scan.c | 3 +++
1 file changed, 3 insertions(+)

--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -1357,6 +1357,9 @@ int acpi_bus_start(struct acpi_device *d
struct acpi_bus_ops ops;

+ if (!device)
+ return -EINVAL;
memset(&ops, 0, sizeof(ops));
ops.acpi_op_start = 1;

 \ /
  Last update: 2010-02-19 18:09    [W:0.303 / U:21.520 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site