Messages in this thread | | | Date | Thu, 18 Feb 2010 09:13:54 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [RFC PATCH 3/3] genericirq: change ack/mask in irq_chip to take irq_desc in addition to irq |
| |
On 02/18/2010 09:04 AM, Eric W. Biederman wrote: > > May I ask why these methods and why pass both irq and desc instead of > just desc? > > I think in the long run passing both irq and desc through several > functions may incur some maintenance cost that it would be nice not to > pay (register pressure and increased chance of typos). >
Indeed; if the IRQ number is needed the function should just get it from desc->irq.
-hpa
| |