lkml.org 
[lkml]   [2010]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 3/3] genericirq: change ack/mask in irq_chip to take irq_desc in addition to irq
On 02/18/2010 09:04 AM, Eric W. Biederman wrote:
>
> May I ask why these methods and why pass both irq and desc instead of
> just desc?
>
> I think in the long run passing both irq and desc through several
> functions may incur some maintenance cost that it would be nice not to
> pay (register pressure and increased chance of typos).
>

Indeed; if the IRQ number is needed the function should just get it from
desc->irq.

-hpa


\
 
 \ /
  Last update: 2010-02-18 18:17    [W:0.126 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site