lkml.org 
[lkml]   [2010]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC PATCH 3/3] genericirq: change ack/mask in irq_chip to take irq_desc in addition to irq
Yinghai Lu <yinghai@kernel.org> writes:

> will have
> void (*ack)(unsigned int irq, struct irq_desc *desc);
> void (*mask)(unsigned int irq, struct irq_desc *desc);
> void (*mask_ack)(unsigned int irq, struct irq_desc *desc);
> void (*unmask)(unsigned int irq, struct irq_desc *desc);
> void (*eoi)(unsigned int irq, struct irq_desc *desc);
>
> so for sparseirq with raidix tree, we don't call extra irq_to_desc, and could use desc directly

This doesn't look bad.

May I ask why these methods and why pass both irq and desc instead of
just desc?

I think in the long run passing both irq and desc through several
functions may incur some maintenance cost that it would be nice not to
pay (register pressure and increased chance of typos).

With a big sweeping change like this I want to be certain we won't
change our minds and come back and want to change it all again.

Oh and a multiarch patch like this should really cc linux-arch
so the arch maintainers can see it.

In passing it looks like want to transform get_irq_data in hpet.c to
get_irq_desc_data.

Eric


\
 
 \ /
  Last update: 2010-02-18 18:07    [from the cache]
©2003-2011 Jasper Spaans