Messages in this thread | | | From | Octavian Purdila <> | Subject | Re: [net-next PATCH v4 1/3] sysctl: refactor integer handling proc code | Date | Thu, 18 Feb 2010 05:58:20 +0200 |
| |
On Tuesday 16 February 2010 09:48:56 you wrote: > On Tuesday 16 February 2010 10:41:07 you wrote: > > > + > > > + if (!write && !first && left && !err) > > > + err = proc_put_newline(&buffer, &left); > > > + if (write && !err) > > > + err = proc_skip_wspace(&buffer, &left); > > > + if (err == -EFAULT /* do we really need to check for -EFAULT? */ > > > || + (write && first)) > > > + return err ? : -EINVAL; > > > > The logic here seems messy, adding one or two goto's may help? > > OK, I'll give it a try. >
After a couple of tries which didn't make it clearer, I've given up. Maybe its not clear, but is not too terribly messy IMO. I'll rather spend time on getting the new list range format done.
| |