lkml.org 
[lkml]   [2010]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [net-next PATCH v4 1/3] sysctl: refactor integer handling proc code
Date
On Tuesday 16 February 2010 09:48:56 you wrote:
> On Tuesday 16 February 2010 10:41:07 you wrote:
> > > +
> > > + if (!write && !first && left && !err)
> > > + err = proc_put_newline(&buffer, &left);
> > > + if (write && !err)
> > > + err = proc_skip_wspace(&buffer, &left);
> > > + if (err == -EFAULT /* do we really need to check for -EFAULT? */
> > > || + (write && first))
> > > + return err ? : -EINVAL;
> >
> > The logic here seems messy, adding one or two goto's may help?
>
> OK, I'll give it a try.
>

After a couple of tries which didn't make it clearer, I've given up. Maybe its
not clear, but is not too terribly messy IMO. I'll rather spend time on
getting the new list range format done.


\
 
 \ /
  Last update: 2010-02-18 02:01    [W:0.310 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site