lkml.org 
[lkml]   [2010]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [net-next PATCH v4 1/3] sysctl: refactor integer handling proc code
Date
On Tuesday 16 February 2010 10:41:07 you wrote:

> > +static int proc_skip_wspace(char __user **buf, size_t *size)
> > +{
> > + char c;
> > +
> > + while (*size) {
> > + if (get_user(c, *buf))
> > + return -EFAULT;
> > + if (!isspace(c))
> > + break;
> > + (*size)--; (*buf)++;
> > + }
> > +
> > + return 0;
> > +}
>
> In lib/string.c we have skip_spaces(), I think we can use it
> here instead of inventing another one.
>

I'm afraid we can't, skip_spaces does not accept userspace buffers.


\
 
 \ /
  Last update: 2010-02-16 12:49    [W:0.091 / U:3.628 seconds]
©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site