lkml.org 
[lkml]   [2010]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/1] Staging: hv: Add proper versioning to HV drivers-Corrected.
On Fri, Feb 12, 2010 at 10:47 AM, Greg KH <gregkh@suse.de> wrote:
> On Fri, Feb 12, 2010 at 05:55:34PM +0000, Hank Janssen wrote:
>>
>> > >
>> > >  drivers/staging/hv/VersionInfo.h |   22 +++++++++++++++++++---
>> >
>> > You forgot a "---" between the signed-off-by and the diffstat.  If you
>> > use either git or quilt, it will get this correct automagically.  That
>> > infers you used something else, which is quite scary.  What are you
>> > using instead to create patches?
>> >
>> > Don't worry, I can edit this by hand when I apply it, and will do so in
>> > a few days when I get to my "to-apply" queue, but in the future, please
>> > don't do this.
>> >
>> > thanks,
>> >
>> > greg k-h
>>
>> This must have been the result of a cut/paste error on my side.
>>
>> I use the following command for my diff   'git diff -M -u --stat'
>
> What's wrong with 'git format-patch'?
>
> You are creating a "raw" diff, which is fine, but you then need to
> include the rest of the comments.  If you commit the patch to a branch,
> with the comments in them, then you can just automatically create the
> patches in correct format.

In case this helps:

http://wireless.kernel.org/en/developers/Documentation/git-guide

Toward s the end there is a git format-patch blurb and explains how to
set up your e-mail client with ssmpt.

Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-02-12 20:43    [W:0.269 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site