lkml.org 
[lkml]   [2010]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] Staging: hv: Add proper versioning to HV drivers-Corrected.
On Fri, Feb 12, 2010 at 05:55:34PM +0000, Hank Janssen wrote:
>
> > >
> > > drivers/staging/hv/VersionInfo.h | 22 +++++++++++++++++++---
> >
> > You forgot a "---" between the signed-off-by and the diffstat. If you
> > use either git or quilt, it will get this correct automagically. That
> > infers you used something else, which is quite scary. What are you
> > using instead to create patches?
> >
> > Don't worry, I can edit this by hand when I apply it, and will do so in
> > a few days when I get to my "to-apply" queue, but in the future, please
> > don't do this.
> >
> > thanks,
> >
> > greg k-h
>
> This must have been the result of a cut/paste error on my side.
>
> I use the following command for my diff 'git diff -M -u --stat'

What's wrong with 'git format-patch'?

You are creating a "raw" diff, which is fine, but you then need to
include the rest of the comments. If you commit the patch to a branch,
with the comments in them, then you can just automatically create the
patches in correct format.

> Btw, it was my understanding that the -M flag allows tracking of renamed
> files as well as part of the diff output. (git mv) But my diff command
> does not report on those. Am I doing something wrong?

You aren't renaming anything :)

Also, don't do that for patches you send through emails, quilt can not
handle them properly, which is what I require for the patches sent to
me. When I queue them up to Linus, git properly figures out renames and
the like, so you don't need to worry about that.

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-02-12 19:57    [W:0.044 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site