Messages in this thread | | | Date | Thu, 11 Feb 2010 08:20:40 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 4/4] drivers: dream: Code style fix |
| |
On Wed 2010-02-10 10:59:37, Jochen Maes wrote: > Removed parenthesis from return statements, > split up assignment and if condition > > Signed-off-by: Jochen Maes <jochen.maes@sejo.be> > --- > drivers/staging/dream/camera/s5k3e2fx.c | 22 ++++++++++++---------- > 1 files changed, 12 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/dream/camera/s5k3e2fx.c b/drivers/staging/dream/camera/s5k3e2fx.c > index edba198..5cb22c8 100644 > --- a/drivers/staging/dream/camera/s5k3e2fx.c > +++ b/drivers/staging/dream/camera/s5k3e2fx.c > @@ -743,12 +743,14 @@ static int s5k3e2fx_sensor_open_init(const struct msm_camera_sensor_info *data) > } > > /* initialize AF */ > - if ((rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr, > - 0x3146, 0x3A)) < 0) > + rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr, > + 0x3146, 0x3A) > + if rc < 0 > goto init_fail1; >
I do not think this is valid C.
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |