Messages in this thread |  | | Date | Thu, 11 Feb 2010 10:22:58 +0200 | Subject | Re: [PATCH 4/4] drivers: dream: Code style fix | From | Pekka Enberg <> |
| |
On Thu, Feb 11, 2010 at 9:20 AM, Pavel Machek <pavel@ucw.cz> wrote: > On Wed 2010-02-10 10:59:37, Jochen Maes wrote: >> Removed parenthesis from return statements, >> split up assignment and if condition >> >> Signed-off-by: Jochen Maes <jochen.maes@sejo.be> >> --- >> drivers/staging/dream/camera/s5k3e2fx.c | 22 ++++++++++++---------- >> 1 files changed, 12 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/staging/dream/camera/s5k3e2fx.c b/drivers/staging/dream/camera/s5k3e2fx.c >> index edba198..5cb22c8 100644 >> --- a/drivers/staging/dream/camera/s5k3e2fx.c >> +++ b/drivers/staging/dream/camera/s5k3e2fx.c >> @@ -743,12 +743,14 @@ static int s5k3e2fx_sensor_open_init(const struct msm_camera_sensor_info *data) >> } >> >> /* initialize AF */ >> - if ((rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr, >> - 0x3146, 0x3A)) < 0) >> + rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr, >> + 0x3146, 0x3A) >> + if rc < 0 >> goto init_fail1; > > I do not think this is valid C.
Yeah, please compile-test trivial cleanups like this before sending them. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |