Messages in this thread | | | From | <> | Date | Mon, 8 Nov 2010 12:08:07 +0100 | Subject | RE: [PATCH] input: spi: Driver for SPI data stream driven vibrator |
| |
Hi,
>From: ext Alan Cox [mailto:alan@lxorguk.ukuu.org.uk] >Sent: 08 November, 2010 01:52 > >> + datalen = p->custom_len * sizeof(p->custom_data[0]); > >signed > >> + if (datalen > MAX_EFFECT_SIZE) { > >unsigned
It should be unsigned. I'll fix it.
>> + memcpy(einfo->buf, p->custom_data, datalen); > >ungood
Yep, that's clearly wrong too. Should be copy_from_user() I suppose.
Thanks, Ilkka
| |