Messages in this thread | | | Date | Tue, 26 Oct 2010 12:17:49 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] input: spi: Driver for SPI data stream driven vibrator |
| |
> > + if (!einfo->buf) { > > + einfo->buf = kzalloc(datalen, GFP_KERNEL | GFP_DMA); > > + if (!einfo->buf) { > > + ret = -ENOMEM; > > + goto exit; > > + } > > + } > > + > > + memcpy(einfo->buf, p->custom_data, datalen); > > It looks like raw data from userspace is being passed on to the > device. Is this sane? Is there already a data format used by other > vibration/feedback devices that should be used here instead and > translated into the form expected by the hardware?
It also seems to be using GFP_DMA not dma_alloc functions which looks a bit odd and certainly isn't portable.
| |