Messages in this thread | | | Date | Sun, 28 Nov 2010 23:25:08 -0500 | From | Rik van Riel <> | Subject | Re: [PATCH v2 2/3] move ClearPageReclaim |
| |
On 11/28/2010 10:02 AM, Minchan Kim wrote: > fe3cba17 added ClearPageReclaim into clear_page_dirty_for_io for > preventing fast reclaiming readahead marker page. > > In this series, PG_reclaim is used by invalidated page, too. > If VM find the page is invalidated and it's dirty, it sets PG_reclaim > to reclaim asap. Then, when the dirty page will be writeback, > clear_page_dirty_for_io will clear PG_reclaim unconditionally. > It disturbs this serie's goal. > > I think it's okay to clear PG_readahead when the page is dirty, not > writeback time. So this patch moves ClearPageReadahead. > This patch needs Wu's opinion.
Acked-by: Rik van Riel <riel@redhat.com>
-- All rights reversed
| |