Messages in this thread | | | Date | Sun, 28 Nov 2010 23:28:05 -0500 | From | Rik van Riel <> | Subject | Re: [PATCH v2 3/3] Prevent promotion of page in madvise_dontneed |
| |
On 11/28/2010 10:02 AM, Minchan Kim wrote: > Now zap_pte_range alwayas promotes pages which are pte_young&& > !VM_SequentialReadHint(vma). But in case of calling MADV_DONTNEED, > it's unnecessary since the page wouldn't use any more. > > If the page is sharred by other processes and it's real working set
This line seems to be superfluous, I don't see any special treatment for this case in the code.
> Signed-off-by: Minchan Kim<minchan.kim@gmail.com> > Cc: Rik van Riel<riel@redhat.com> > Cc: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com> > Cc: Johannes Weiner<hannes@cmpxchg.org> > Cc: Nick Piggin<npiggin@kernel.dk> > Cc: Mel Gorman<mel@csn.ul.ie> > Cc: Wu Fengguang<fengguang.wu@intel.com>
The patch itself looks good to me.
Acked-by: Rik van Riel <riel@redhat.com>
-- All rights reversed
| |