Messages in this thread Patch in this message | | | Subject | [PATCH 4/5] ASoC: Fix incorrect kfree in wm8731_probe error path | From | Axel Lin <> | Date | Tue, 16 Nov 2010 16:10:41 +0800 |
| |
We allocated memory for wm8731 in wm8731_spi_probe / wm8731_i2c_probe, and will free the memory in either wm8731_spi_probe / wm8731_i2c_probe error path or wm8731_spi_remove / wm8731_i2c_remove.
Thus we should not call kfree(wm8731) in wm8731_probe, otherwise we have double free of wm8731.
Signed-off-by: Axel Lin <axel.lin@gmail.com> --- sound/soc/codecs/wm8731.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c index 95ade32..4b70958 100644 --- a/sound/soc/codecs/wm8731.c +++ b/sound/soc/codecs/wm8731.c @@ -543,7 +543,6 @@ err_regulator_enable: err_regulator_get: regulator_bulk_free(ARRAY_SIZE(wm8731->supplies), wm8731->supplies); - kfree(wm8731); return ret; } -- 1.7.2
| |