Messages in this thread Patch in this message | | | Subject | [PATCH 2/5] ASoC: Fix incorrect kfree in ad193x_probe error path | From | Axel Lin <> | Date | Tue, 16 Nov 2010 16:08:51 +0800 |
| |
We allocated memory for ad193x in ad193x_spi_probe, and will free the memory in either ad193x_spi_probe error path or ad193x_spi_remove.
Thus we should not call kfree(ad193x) in ad193x_probe, otherwise we have double free of ad193x.
Signed-off-by: Axel Lin <axel.lin@gmail.com> --- sound/soc/codecs/ad193x.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/ad193x.c b/sound/soc/codecs/ad193x.c index dc105d8..fd3e659 100644 --- a/sound/soc/codecs/ad193x.c +++ b/sound/soc/codecs/ad193x.c @@ -364,7 +364,6 @@ static int ad193x_probe(struct snd_soc_codec *codec) if (ret < 0) { dev_err(codec->dev, "failed to set cache I/O: %d\n", ret); - kfree(ad193x); return ret; } -- 1.7.2
| |