lkml.org 
[lkml]   [2010]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/9] vfs: protect remounting superblock read-only
On Tue, Oct 05, 2010 at 12:31:15PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> Currently remouting superblock read-only is racy in a major way.
>
> With the per mount read-only infrastructure it is now possible to
> prevent most races, which this patch attempts.
>
> Before starting the remount read-only, set MNT_WRITE_HOLD on all
> mounts so that writes are held off until the remount either succeeds
> or fails.

Umm... What'll happen if your remount will say mnt_want_write() on
e.g. internal vfsmount over that sb? Or, more subtle, tries to
update atime on some opened struct file on that sb.


\
 
 \ /
  Last update: 2010-10-22 08:49    [W:0.104 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site