Messages in this thread Patch in this message | | | Date | Fri, 15 Oct 2010 17:25:15 +0200 | From | Tejun Heo <> | Subject | [PATCH v2.6.36-rc7] memory_hotplug: drop spurious calls to flush_scheduled_work() |
| |
lru_add_drain_all() uses schedule_on_each_cpu() which is synchronous. There is no reason to call flush_scheduled_work() after lru_add_drain_all(). Drop the spurious calls.
This is to prepare for the deprecation and removal of flush_scheduled_work().
Signed-off-by: Tejun Heo <tj@kernel.org> --- mm/memory_hotplug.c | 2 -- 1 file changed, 2 deletions(-)
Index: work/mm/memory_hotplug.c =================================================================== --- work.orig/mm/memory_hotplug.c +++ work/mm/memory_hotplug.c @@ -840,7 +840,6 @@ repeat: ret = 0; if (drain) { lru_add_drain_all(); - flush_scheduled_work(); cond_resched(); drain_all_pages(); } @@ -862,7 +861,6 @@ repeat: } /* drain all zone's lru pagevec, this is asyncronous... */ lru_add_drain_all(); - flush_scheduled_work(); yield(); /* drain pcp pages , this is synchrouns. */ drain_all_pages();
| |