lkml.org 
[lkml]   [2010]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] Obsolete config in kernel source (BEFS_RW)
Hi all!

As part of the VAMOS[0] research project at the University of
Erlangen we're checking referential integrity between kernel KConfig
options and in-code Conditional blocks.

The BEFS filesystem Code has a check for CONFIG_BEFS_RW which
seems to have no counterpart in linux KConfig in git's history. Maybe
you want to remove the check and always assume it would fail (as is
done with the attached patch).

Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.

Regards

Christoph Egger

From 0f1656a6df5ffbfcc22b6a73522b4c41b190ac7a Mon Sep 17 00:00:00 2001
From: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
Date: Fri, 29 Jan 2010 14:03:12 +0100
Subject: [PATCH] Drop obsolete config BEFS_RW

CONFIG_BEFS_RW doesn't have any counterpart in KConfig since virtually
ever and there's only one place in the kernel where it is (still?)
checked.

This patch removes the obsolete check (alwazs evaluates to true).

Signed-off-by: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
---
fs/befs/linuxvfs.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
index 33baf27..4c3e342 100644
--- a/fs/befs/linuxvfs.c
+++ b/fs/befs/linuxvfs.c
@@ -778,13 +778,11 @@ befs_fill_super(struct super_block *sb, void *data, int silent)

befs_debug(sb, "---> befs_fill_super()");

-#ifndef CONFIG_BEFS_RW
if (!(sb->s_flags & MS_RDONLY)) {
befs_warning(sb,
"No write support. Marking filesystem read-only");
sb->s_flags |= MS_RDONLY;
}
-#endif /* CONFIG_BEFS_RW */

/*
* Set dummy blocksize to read super block.
--
1.6.3.3
\
 
 \ /
  Last update: 2010-01-29 14:15    [W:0.020 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site