Messages in this thread | | | Date | Thu, 28 Jan 2010 22:54:32 +0100 | From | Frederic Weisbecker <> | Subject | Re: [PATCH 1/4] x86,hw_breakpoint,kgdb: kgdb to usehw_breakpointAPI |
| |
On Thu, Jan 28, 2010 at 02:23:13PM -0600, Jason Wessel wrote: > Frederic Weisbecker wrote: > > On Thu, Jan 28, 2010 at 01:58:26PM -0600, Jason Wessel wrote: > > > >> New version which loses the call back registration, because if we > >> register as a different breakpoint type, perf won't reject it. > >> > > > > > > > > I don't understand what you mean here. > > > > > > > > > > This was the change: > > - attr.bp_type = HW_BREAKPOINT_X; > + attr.bp_type = HW_BREAKPOINT_W; > > The perf API had extra constraint checks when you did not have a call > back function and the type was HW_BREAKPOINT_X. Using the > HW_BREAKPOINT_W type avoids the extra checks that would not allow me to > register without providing a call back.
Oh, where have you seen this?
> > Ok. Well, let's go for it, as it's a regression that > > needs to be fixed anyway. > > > > But we'll need to sanitize various things after that :) > > > > > Agreed. > > Can I take that to mean you have acked this version of the patch? > > Thanks, > Jason.
Yep, please add my ack.
Thanks!
| |