Messages in this thread | | | Date | Thu, 28 Jan 2010 21:17:47 +0100 | From | Frederic Weisbecker <> | Subject | Re: [PATCH 1/4] x86,hw_breakpoint,kgdb: kgdb to use hw_breakpointAPI |
| |
On Thu, Jan 28, 2010 at 01:58:26PM -0600, Jason Wessel wrote: > New version which loses the call back registration, because if we > register as a different breakpoint type, perf won't reject it.
I don't understand what you mean here.
> I didn't > see that loop hole in the API the first time around. > > Also the dr7 fixup in hw_breakpoint.c is not needed. > > The trickery for entering twice into the __kgdb_notify is gone too. > > All the regression tests are still passing.
Ok. Well, let's go for it, as it's a regression that needs to be fixed anyway.
But we'll need to sanitize various things after that :)
| |