Messages in this thread | | | Date | Fri, 1 Jan 2010 18:07:29 +0100 | From | Andreas Mohr <> | Subject | Re: [PATCH] PCI / PM: Use per-device D3 delays |
| |
Hi,
While the bug report mentions "So it's just quirky hardware.", the implementation of your patch makes it seem like this delay attribute is totally "norm"al behaviour - I'm missing some more aggressive wording.
Perhaps rename d3_delay to d3_delay__quirk or add something to the comment, like "D3->D0 transition time in ms (out-of-spec PCI device quirk)"? Or maybe something like "custom D3->D0 transition time in ms (for quirky hardware violating the PCI spec's <= 100ms)".
Thanks for your ongoing great PCI efforts,
Andreas Mohr
| |