Messages in this thread | | | Date | Wed, 09 Sep 2009 17:44:23 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] x86: SGU UV Add volatile to macros that access chipset registers |
| |
On 09/09/2009 12:38 PM, Jack Steiner wrote: > > static inline void uv_write_local_mmr8(unsigned long offset, unsigned char val) > { > - *((unsigned char *)uv_local_mmr_address(offset)) = val; > + *((volatile unsigned char *)uv_local_mmr_address(offset)) = val; > } >
Why aren't you simply using __writeb() here, and the other memory accessors we already have in the other places?
-hpa
| |