lkml.org 
[lkml]   [2009]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86: SGU UV Add volatile to macros that access chipset registers
    On Wed, Sep 09, 2009 at 05:44:23PM -0700, H. Peter Anvin wrote:
    > On 09/09/2009 12:38 PM, Jack Steiner wrote:
    > >
    > > static inline void uv_write_local_mmr8(unsigned long offset, unsigned char val)
    > > {
    > > - *((unsigned char *)uv_local_mmr_address(offset)) = val;
    > > + *((volatile unsigned char *)uv_local_mmr_address(offset)) = val;
    > > }
    > >
    >
    > Why aren't you simply using __writeb() here, and the other memory
    > accessors we already have in the other places?

    Excellent idea. New patch to follow...


    --- jack


    \
     
     \ /
      Last update: 2009-09-10 04:23    [W:0.034 / U:29.564 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site