lkml.org 
[lkml]   [2009]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 65/71] can: Fix raw_getname() leak
    2.6.30-stable review patch.  If anyone has any objections, please let us know.

    ------------------
    From: Eric Dumazet <eric.dumazet@gmail.com>

    commit e84b90ae5eb3c112d1f208964df1d8156a538289 upstream.

    raw_getname() can leak 10 bytes of kernel memory to user

    (two bytes hole between can_family and can_ifindex,
    8 bytes at the end of sockaddr_can structure)

    Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
    Acked-by: Oliver Hartkopp <oliver@hartkopp.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    net/can/raw.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/can/raw.c
    +++ b/net/can/raw.c
    @@ -397,6 +397,7 @@ static int raw_getname(struct socket *so
    if (peer)
    return -EOPNOTSUPP;

    + memset(addr, 0, sizeof(*addr));
    addr->can_family = AF_CAN;
    addr->can_ifindex = ro->ifindex;




    \
     
     \ /
      Last update: 2009-09-05 02:27    [W:0.028 / U:0.400 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site