lkml.org 
[lkml]   [2009]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 64/71] xenfb: connect to backend before registering fb
    2.6.30-stable review patch.  If anyone has any objections, please let us know.

    ------------------
    From: Michal Schmidt <mschmidt@redhat.com>

    commit 0a80fb10239b04c45e5e80aad8d4b2ca5ac407b2 upstream.

    As soon as the framebuffer is registered, our methods may be called by the
    kernel. This leads to a crash as xenfb_refresh() gets called before we have
    the irq.

    Connect to the backend before registering our framebuffer with the kernel.

    [ Fixes bug http://bugzilla.kernel.org/show_bug.cgi?id=14059 ]

    Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
    Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/video/xen-fbfront.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/drivers/video/xen-fbfront.c
    +++ b/drivers/video/xen-fbfront.c
    @@ -454,6 +454,10 @@ static int __devinit xenfb_probe(struct

    xenfb_init_shared_page(info, fb_info);

    + ret = xenfb_connect_backend(dev, info);
    + if (ret < 0)
    + goto error;
    +
    ret = register_framebuffer(fb_info);
    if (ret) {
    fb_deferred_io_cleanup(fb_info);
    @@ -464,10 +468,6 @@ static int __devinit xenfb_probe(struct
    }
    info->fb_info = fb_info;

    - ret = xenfb_connect_backend(dev, info);
    - if (ret < 0)
    - goto error;
    -
    xenfb_make_preferred_console();
    return 0;




    \
     
     \ /
      Last update: 2009-09-05 02:27    [W:4.991 / U:6.004 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site