Messages in this thread | | | Date | Tue, 15 Sep 2009 21:14:19 +0200 | From | Marcin Slusarz <> | Subject | Re: V4L2 drivers: potentially dangerous and inefficient msecs_to_jiffies() calculation |
| |
Andreas Mohr pisze: > Hi all, > > ./drivers/media/video/sn9c102/sn9c102_core.c > , > ./drivers/media/video/et61x251/et61x251_core.c > and > ./drivers/media/video/zc0301/zc0301_core.c > do > cam->module_param.frame_timeout * > 1000 * msecs_to_jiffies(1) ); > multiple times each. > What they should do instead is > frame_timeout * msecs_to_jiffies(1000), I'd think.
Or better: frame_timeout * HZ
Marcin
| |