lkml.org 
[lkml]   [2009]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: V4L2 drivers: potentially dangerous and inefficient msecs_to_jiffies() calculation
    On 09/14/2009 11:07 PM, Andreas Mohr wrote:
    > ./drivers/media/video/zc0301/zc0301_core.c
    > do
    > cam->module_param.frame_timeout *
    > 1000 * msecs_to_jiffies(1) );
    > multiple times each.
    > What they should do instead is
    > frame_timeout * msecs_to_jiffies(1000), I'd think.

    In fact, msecs_to_jiffies(frame_timeout * 1000) makes much more sense.

    > msecs_to_jiffies(1) is quite a bit too boldly assuming
    > that all of the msecs_to_jiffies(x) implementation branches
    > always round up.

    They do, don't they?


    \
     
     \ /
      Last update: 2009-09-14 23:37    [W:0.022 / U:60.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site