Messages in this thread | | | Date | Mon, 14 Sep 2009 16:30:33 -0400 (EDT) | From | "Robert P. J. Day" <> | Subject | test for "spurious" IRQ ignores possible IRQ_WAKE_THREAD value |
| |
never ashamed to embarrass myself in public, i just noticed the following. from kernel/irq/spurious.c:
... static void __report_bad_irq(unsigned int irq, struct irq_desc *desc, irqreturn_t action_ret) { struct irqaction *action;
if (action_ret != IRQ_HANDLED && action_ret != IRQ_NONE) { printk(KERN_ERR "irq event %d: bogus return value %x\n", irq, action_ret);
but from include/linux/irqreturn.h, we see *three* possible return values:
enum irqreturn { IRQ_NONE, IRQ_HANDLED, IRQ_WAKE_THREAD, };
typedef enum irqreturn irqreturn_t; #define IRQ_RETVAL(x) ((x) != IRQ_NONE)
is there an inconsistency here?
rday --
======================================================================== Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday ========================================================================
| |