lkml.org 
[lkml]   [2009]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] w1_gpio: switch to new dev_pm_ops
On Wed, Aug 05, 2009 at 08:44:01PM +0200, Rafael J. Wysocki wrote:
> > +static struct dev_pm_ops w1_gpio_pm_ops = {
> > + .suspend = w1_gpio_suspend,
> > + .freeze = w1_gpio_suspend,
> > + .resume = w1_gpio_resume,
> > + .thaw = w1_gpio_resume,
>
> You need
>
> + .poweroff = w1_gpio_suspend,
> + .restore = w1_gpio_resume,
>
> in addition to these, which seems to be the case with the rest of the patches
> too.
>
> If you wait for a little while with the patchset, we're going to have a
> convenience macro for defining such 'standard' dev_pm_ops objects.

Ok, fine. Letting them all point the same function looks somwhat hackish
to me, so I'll wait for that macro. Let me know when that has arrived :)

Daniel


\
 
 \ /
  Last update: 2009-08-05 20:47    [from the cache]
©2003-2011 Jasper Spaans