lkml.org 
[lkml]   [2009]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/5] pda-power: switch to new dev_pm_ops
From
On Thu, Aug 6, 2009 at 12:29 AM, Daniel Mack<daniel@caiaq.de> wrote:
> On Wed, Aug 05, 2009 at 09:49:52PM +0200, Frans Pop wrote:
>> Daniel Mack wrote:
>> > +static struct dev_pm_ops pda_power_pm_ops = {
>> > +       .suspend        = pda_power_suspend,
>> > +       .freeze         = pda_power_freeze,
>>
>> Hmmm. Where's pda_power_freeze defined? Forgot to (compile)test the
>> patches?
>
> Yes, sorry. I can't test hibernation, so I didn't pay enough attention.
> I'll resend them anyway with Rafael's new macro used.

After Rafael's comments on gpio_keys, I believe also here
.freeze/.thaw should be empty. enable/disable_irq_wake should be
called from .poweroff/.restore.

regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-08-06 13:55    [W:0.030 / U:0.332 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site