Messages in this thread Patch in this message | | | Date | Wed, 19 Aug 2009 15:18:14 +0200 | From | Simon Kagstrom <> | Subject | Re: [PATCH v2] [ARM] Kirkwood: Marvell OpenRD-Base board support added to v2.6.31-rc5 |
| |
Hi Dhaval!
On Mon, 10 Aug 2009 17:37:34 +0530 Dhaval Vasa <dhaval.vasa@einfochips.com> wrote:
> reference: > http://open-rd.org > http://code.google.com/p/openrd > > This patch is tested for: > 1. Boot from DRAM/NAND flash > 2. NAND read/write/erase > 3. GbE0 > 4. USB read/write > > FIXME: > 1. SD/UART1 selection > 2. MPP configuration (currently, default) > 3. PEX > > Signed-off-by: Dhaval Vasa <dhaval.vasa@einfochips.com>
Tested-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> +static unsigned int openrd_base_mpp_config[] __initdata = { > + MPP29_GPIO, ^^^^^ There is trailing whitespace on this line
Also, I'd suggest merging "[PATCH v2] Kirkwood: Initialise SATA for OpenRD-Base" into this one and resubmit it.
In my patch, I also called kirkwood_i2c_init (see below), which at least make the I2C bus appear (not that I've tested it very much).
// Simon
diff --git a/arch/arm/mach-kirkwood/openrd_base-setup.c b/arch/arm/mach-kirkwood/openrd_base-setup.c index f9a2166..dc0a2fe 100644 --- a/arch/arm/mach-kirkwood/openrd_base-setup.c +++ b/arch/arm/mach-kirkwood/openrd_base-setup.c @@ -71,6 +71,8 @@ static void __init openrd_base_init(void) kirkwood_ge00_init(&openrd_base_ge00_data); kirkwood_sata_init(&openrd_base_sata_data); kirkwood_sdio_init(&openrd_base_mvsdio_data); + + kirkwood_i2c_init(); } MACHINE_START(OPENRD_BASE, "Marvell OpenRD Base Board")
| |