lkml.org 
[lkml]   [2009]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] [ARM] Kirkwood: Marvell OpenRD-Base board support added to v2.6.31-rc5
On Wed, 19 Aug 2009 19:19:29 +0530
Dhaval Vasa <dhaval.vasa@einfochips.com> wrote:

> >> +static unsigned int openrd_base_mpp_config[] __initdata = {
> >> + MPP29_GPIO,
> > ^^^^^
> > There is trailing whitespace on this line
> >
> Nicolas has already applied this patch on his orion tree; it would be
> worth generating separate one for whitespace ? Suggest.

Maybe not, I'm not sure what the procedure is. I didn't realise it was
already there - I was looking at another git tree :-)

> > Also, I'd suggest merging "[PATCH v2] Kirkwood: Initialise SATA for
> > OpenRD-Base" into this one and resubmit it.
>
> Nicolas has already applied this patch on his orion tree. Should I
> re-submit now ?

Well, if it's already there I think it's fine as it is. I thought the
patch was still under consideration.

> Can you point me to your patch ?

I posted it about a month ago on this list, see:

http://www.spinics.net/lists/arm-kernel/msg70680.html

I guess you can apply the patch I sent in the last mail to the Orion
tree if it's acceptable - that's basically the diff between my old
patch and the new one you sent.

// Simon


\
 
 \ /
  Last update: 2009-08-19 16:21    [W:0.045 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site